Firefox update script

@quedayone

First off, THANK YOU!

Trying your script on a 10.12.5 machine with no firefox installed, i'm getting this.

Script result: <br/>Starting Firefox ESR installer script Jul, 03 2017 04:12:41 PM
<br/>Downloading latest version. . . <br/>current: none<br/>latest: 52.2.1<br/>
<br/>Traceback (most recent call last):<br/> File "/Library/Application Support/JAMF/tmp/Firefox Update & Install", line 87, in <module><br/> if int(currentFirefoxVersion) >= int(latestFirefoxVersion):<br/>ValueError: invalid literal for int() with base 10: 'none'<br/>

I fixed a small part of the code, changing 'none' to 0.

# # Get currently installed version of Firefox
if isfile(plistFile):
    pl = readPlist(plistFile)
    currentFirefoxVersion=pl["CFBundleShortVersionString"]
else:
    currentFirefoxVersion="0"
#

@bcheney Sweet! Thank you. I have updated on my git hub.

@quedayone

Seeing one other issue --

My App icon is showing up as the standard pen/pencil and paper Application icon, but not the Firefox logo (on dock and in apps folder). But if I open finder, copy and paste the logo onto itself, it asks for admin rights and fixes itself. Any idea? Can something be done to alleviate the issue?

Thanks again!

@joe.farage

I would like to start by saying thanks for the script, it is just what I needed. So after I downloaded your script to update a few laptops running an old version of Firefox jamf showed it as failed. It fails every time when I am running it out of jamf. However, if I run it manually on the laptop from terminal using sudo it works correctly. Do you by chance have any ideas as to why this may be occurring?

Thanks in advance :)

@tkimpton, I'v been using your script and I was wondering how I could inspect the status of the downloaded app signature.

I found that I can check the app signature with the command;
codesign --verify --verbose /Volumes/Firefox/Firefox.app

the result is;
/Volumes/Firefox/Firefox.app: valid on disk
/Volumes/Firefox/Firefox.app: satisfies its Designated Requirement

I haven't been able to figure out a way to test the result in the script and exit if it fails.

@bcheney

I have the same issue with the app icon on latest High Sierra 10.13.6 using this script.
It's something tied to icon cache, tried a few things, like deleting icon cache in /private/var/folders but didn't work.

What worked was just "touching" the app:

sudo touch /Applications/Firefox.app

Someone also said that if this is not enough maybe touching the Info.plist inside the Contents folder, but for me always worked just with the .app

sudo touch /Applications/Firefox.app/Contents/Info.plist

And also, what I found out, this happens only for the user that is logged in when the script runs, and I think a log out/restart will fix it by itself.