help with comp name script

So, I was looking for a random post to do my #100daysofcode tonight and this was the first post that asked for script help. So, here is my Python version of this. It does not require TCC/PPPC and I tried to mimic your requirements as well as I could. Basically if you can get rid of the tell application parts of Applescripts in 10.14+ you can avoid a lot of the TCC/PPPC prompts.

#!/usr/bin/python

import subprocess
from SystemConfiguration import SCDynamicStoreCopyConsoleUser
import sys
import plistlib

# vars for current user
USER, UID, GID = SCDynamicStoreCopyConsoleUser(None, None, None)
# dialogs
BRAND = """
set BRAND to text returned of (display dialog "Please input the brand - AA = AA, AB = AB, AC = AC," default answer "" with title "Brand")
"""
LOCATION = """
set MacLoc to text returned of (display dialog "Please enter the location - BA = BA, BB = BB, BC = BC" default answer "" with title "Location")
"""
DEPARTMENT = """
set DEPARTMENT to text returned of (display dialog "Please enter department - 01 = 01, 02 = 02, " default answer "" with title "Department")
"""
MODEL = """
set MacTYPE to text returned of (display dialog "Please input the machine type - MD = Desktop, ML = Laptop, " default answer "" with title "Mac Model")
"""
# functions

def get_serial():
    """get last 7 characters of serial number"""
    # system profiler command
    cmd = ["system_profiler", "SPHardwareDataType", "-xml"]
    # run the command
    proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
    out, err = proc.communicate()
    # load output into a var
    data = plistlib.readPlistFromString(out)
    # grab sreial number, mutate serail to last 7 characters
    serial = data[0]["_items"][0]["serial_number"]
    serial = serial[-7:]

    return serial


def computer_name(name):
    """name computer function"""
    # options for scutil, since macOS has 3 hostnames
    options = ["HostName", "ComputerName", "LocalHostName"]
    # loop through options and pass the name to set it
    for option in options:
        subprocess.call(["scutil", "--set", option, name])


def osascript(osastring):
    """Wrapper to run AppleScript commands"""
    # command to run the applescripts
    cmd = ['/usr/bin/osascript', '-e', osastring]
    # execute subprocess with commands
    proc = subprocess.Popen(cmd, shell=False, bufsize=1,
                            stdin=subprocess.PIPE,
                            stdout=subprocess.PIPE, stderr=subprocess.PIPE)
    (out, err) = proc.communicate()
    # test for non zero exit status
    if proc.returncode != 0:
        print('Error: ', err.decode('UTF-8'))
    # if we get output return it
    if out:
        return out.decode('UTF-8').rstrip('
')
    return u''


def main():
    """run the logic"""
    # if at login window USER will return None
    # exit if we find _mbsetupuser
    if USER is not None and USER != "_mbsetupuser":
        # prompt for brand
        brand = osascript(BRAND).decode('utf-8')
        # prompt for location
        loc = osascript(LOCATION).decode('utf-8')
        # prompt for department
        dept = osascript(DEPARTMENT).decode('utf-8')
        # get the last 7 characters of the serial number
        ser = get_serial()
        # prompt for model
        model = osascript(MODEL).decode('utf-8')
        # build the computer name
        name = str(model + brand + loc + dept + ser)
        # set the computer name
        computer_name(name)
    else:
        # if at login window or _mbsetupuser found, exit
        sys.exit(0)


if __name__ == "__main__":
    main()

if you wanted all the characters to be uppercase too, that would be super easy to do in Python, just call .upper() to capitalize them.

Hope this helps, and thanks for the problem so I can count this toward my #100daysofcode