script help

@jwojda How about this for determining Mac type:

1model=$(ioreg -l | grep "product-name" | cut -d "=" -f 2 | sed -e s/[^[:alnum:]]//g | sed s/[0-9]//g)
2# Default to a Desktop
3TT="MD"
4isMacbook=$(echo "$model" | grep "Book")
5if [[ $isMacbook != "" ]]; then
6    TT="ML"
7fi

@sdagley same result. I did have to put $isMacBook into "$isMacbook" to make it not error out, but after doing that it still went to MD

I gave the code from your original post a run and it's properly returning ML for me. Might I suggest echoing out $ModelType before the IF statement and see what value it's entering that statement with? Maybe awk is cutting things off that we're not expecting?

Also, just a side note for defining variables, TT would be a string, so I'd recommend redoing those assignments to:

1TT="MD"

Not the most essential thing in the world, and certainly isn't the issue here, but it's a decent practice to make sure your variable types are always correctly defined :)

This is what I use as a template when I want to set different things depending if it's a macbook or not...

1# Detects if this Mac is a laptop or not by checking the model ID for the word "Book" in the name.
2IS_LAPTOP=$(/usr/sbin/system_profiler SPHardwareDataType | grep "Model Identifier" | grep "Book")
3modelName=$(/usr/sbin/system_profiler SPHardwareDataType | awk -F': ' ' /Model Name/{print $NF}')
4
5if [ "$IS_LAPTOP" != "" ]; then
6    /usr/bin/pmset -b sleep 15 disksleep 10 displaysleep 5 halfdim 1
7    /usr/bin/pmset -c sleep 0 disksleep 0 displaysleep 30 halfdim 1
8else    
9    /usr/bin/pmset sleep 0 disksleep 0 displaysleep 30 halfdim 1
10fi

I like reading the system_profiler data into Python's plistlib because then you can just parse the dictionary outputs pretty easily, an example I just whipped up:

1#!/usr/bin/python
2
3import subprocess
4import plistlib
5
6def get_device_model():
7    cmd = ['/usr/sbin/system_profiler', 'SPHardwareDataType', '-xml']
8    proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
9    out, err = proc.communicate()
10    data = plistlib.readPlistFromString(out)
11    model = data[0]['_items'][0]['machine_model']
12    return model
13
14
15model = get_device_model()
16
17if 'MacBook' in model:
18    print('MacBook Found')

When I run the code on my MacBook Pro:

1/usr/bin/python2.7 /Users/tlarkin/IdeaProjects/test/get_model.py
2MacBook Found

All of these items could be parsed and tested against in code using a simple dictionary as well. This is truncated output in plist format from the shell, it puts them into a dictionary with the key as _items and then key value for the rest of the data

1<key>_items</key>
2        <array>
3            <dict>
4                <key>_name</key>
5                <string>hardware_overview</string>
6                <key>boot_rom_version</key>
7                <string>220.270.99.0.0 (iBridge: 16.16.6568.0.0,0)</string>
8                <key>cpu_type</key>
9                <string>Intel Core i9</string>
10                <key>current_processor_speed</key>
11                <string>2.9 GHz</string>
12                <key>l2_cache_core</key>
13                <string>256 KB</string>
14                <key>l3_cache</key>
15                <string>12 MB</string>
16                <key>machine_model</key>
17                <string>MacBookPro15,1</string>
18                <key>machine_name</key>
19                <string>MacBook Pro</string>
20                <key>number_processors</key>
21                <integer>6</integer>
22                <key>packages</key>
23                <integer>1</integer>
24                <key>physical_memory</key>
25                <string>32 GB</string>
26                <key>platform_UUID</key>
27                <string>53685B89-8388-55AF-A129-3B8EC1ED00C1</string>
28                <key>platform_cpu_htt</key>
29                <string>htt_enabled</string>
30                <key>serial_number</key>
31                <string>C02XG4K6JGH5</string>
32            </dict>
33        </array>

Hope this helps some of y'all

For waiting for a prompt you can build a loop around that and break the loop once you have desired input, and for bonus points you can count how many times the loop runs, or give it a time out before calling break in code and moving forward.

This is what we use for renaming.

1#!/bin/bash
2
3##############################################################################################################
4# renameMacCSV.sh
5# Modified by Reggie Santos 
6# Last modified 05/31/2018
7# add auto-prefix function using system_profiler SPHardwareDataType | grep "Model Identifier" if not using Custom Prefix in parameter $4
8
9#Written by: Frederick Abeloos | Field Technician | Jamf 
10#Created On: March 8th, 2018 / script is provided "AS IS" /
11
12#Purpose: Jamf Pro @enrollment script to rename the mac prior to binding to AD (optional)
13
14#Put this script in a policy with option AFTER (important when using .pkg)
15
16#Upload a pkg in JamfPro which puts an assettag.csv file in /tmp/assettags.csv
17#First column serialnumber and second column the desired assettag
18
19#OR use CURL to download any .csv from a public link
20
21# Optional: Create a policy with the directory binding payload and custom trigger 'bindToAD'
22
23##############################################################################################################
24
25### RENAMING SETTINGS ########################################################################################
26
27# Don't change any settings here. Use $4-$9 parameters in Jamf Pro script payload options.
28
29# First choose a naming convention for your Mac.
30# Custom Prefix can be set via the $4 parameter in the Jamf Pro policy.
31# Leave the parameter $4 in Jamf Pro empty if you like to auto-prefix computername base on "Model Identifier", e.g. type "MBP-" (without the quotes). 
32prefix="$4"
33# Suffix will be set via the $5 parameter in the Jamf Pro policy (script payload).
34# Leave the parameter empty if no suffix is required. e.g. type "Mac_" (without the quotes).
35suffix="$5"
36# Choose serialnumber or assettag via the $6 parameter in the Jamf Pro policy (script payload).
37# Set it to "serialnumber" or "assettag" (without the quotes).
38namingType="$6"
39# Define if you are adding the .pkg with the /tmp/assettags.csv file or using curl to download any .csv file.
40# When using curl, the script below will download and rename the file to /tmp/assettags.csv
41# Type will be set via $7 paremeter in the Jamf Pro Policy. Type "curl" or "package" (without the quotes).
42csvType="$7"
43# Define the public link to the .csv file. Leave blank when using .pkg
44# Link will be set via th $8 parameter in the Jamf Pro policy. Add the full "https://URL" (without the quotes).
45csvURL="$8"
46# Path to local csv file, via package in same policy: pkg putting assettags.csv in /tmp/
47csvPath="/tmp/assettags.csv"
48# Do you want to bind or not? Set to "bind" or leave blank
49bindSetting="$9"
50
51### RENAMING SCRIPT ########################################################################################
52MBA=`/usr/sbin/system_profiler SPHardwareDataType | grep "Model Identifier" | grep "BookAir"`
53
54MBP=`/usr/sbin/system_profiler SPHardwareDataType | grep "Model Identifier" | grep "BookPro"`
55
56if [ "$4" == "" ] && [ "$MBP" == "" ] && [ "$MBA" != "" ]; then
57    prefix="MBA"
58elif [ "$4" == "" ] && [ "$MBA" == "" ] && [ "$MBP" != "" ]; then
59    prefix="MBP"
60elif [ "$4" == "" ] && [ "$MBA" == "" ] && [ "$MBP" == "" ]; then
61    prefix="MAC"
62
63fi
64
65if [ "$csvType" = "curl" ]; then
66
67    curl -L -o $csvPath $csvURL
68
69fi
70
71
72
73if [ "$namingType" = "serialnumber" ]; then
74
75    echo "using serialnumber"
76    jamf setComputerName -useSerialNumber -prefix $prefix -suffix $suffix
77
78elif  [ "$namingType" = "assettag" ]; then
79
80    echo "using assettag" 
81    jamf setComputerName -fromFile "$csvPath" -prefix $prefix -suffix $suffix
82
83fi
84
85### AD BINDING ###########################################################################################
86
87if [ "$bindSetting" = "bind" ]; then
88
89    echo "Binding to AD"
90
91    jamf policy -event bindToAD
92
93else echo "Not binding"
94
95fi
96
97
98### CLEAN UP #############################################################################################
99
100#delete the assettags.csv
101
102rm "$csvPath"
103
104#update Jamf Pro inventory
105jamf recon